Launcher Draft 1 #98
Launcher Draft 1 #98
Conversation
|
i like the idea! one thing i would do differently is to NOT inherit from QObject in any of the base plugin classes however (you can find plenty of conversations about it on qplugin related posts) you can however have virtual signals (e.g here) which i think would be the ideal approach |
| echo Running Dash make | ||
| make | ||
|
|
||
| coreQ=$(grep 'cpu cores' /proc/cpuinfo | uniq) |
There was a problem hiding this comment.
id maybe not squeeze this in here... see #88 for a discussion on setting the number of cores programmatically like this
There was a problem hiding this comment.
@rsjudka I was hoping you'd have an opinion on that, it didn't feel right but It also didn't work when I tried to inherit lower down. Thanks for pointing me in the right direction, I'm still a little newer to qt so I appreciate the advice! Also I agree about not changing the install script here, I just did it because it speeds up my build on my dev machine but I don't think this would even work on the rpi as is. I'll try and remember to remove this, I'll let that be it's own issue
Description:
Preliminary changes to launcher to accommodate simultaneously opened apps from a single plugin instance. Additional changes to install script for multi core make and changed install script depedencies to support Ubuntu repos.
Checklist: